Add the required package source for the “Microsoft.Android.Ref.34” package in MAUI test cases #6235
Conversation
| @@ -187,6 +189,7 @@ public async Task UninstallPackageForPRInPMC(ProjectTemplate projectTemplate) | |||
|
|
|||
| await CommonUtility.CreatePackageInSourceAsync(simpleTestPathContext.PackageSource, PackageName, v100); | |||
| simpleTestPathContext.Settings.AddSource(NuGetConstants.NuGetHostName, NuGetConstants.V3FeedUrl); | |||
| simpleTestPathContext.Settings.AddSource("AndroidFeed", "https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-android-a8cd27e4/nuget/v3/index.json"); | |||
There was a problem hiding this comment.
Since we have it 3x, let's use a share string for the feed url.
| @@ -7,13 +7,15 @@ public static class NuGetConstants | |||
| { | |||
| public static readonly string NuGetHostName = "nuget.org"; | |||
| public static readonly string NuGetSymbolHostName = "nuget.smbsrc.net"; | |||
| public static readonly string AndroidFeedName = "AndroidFeed"; | |||
There was a problem hiding this comment.
This is part of the NuGet-SDK, public APIs of this assembly are shipped within packages.
Changes need to follow the process defined in https://github.com/NuGet/NuGet.Client/blob/dev/docs/nuget-sdk.md#changes-to-apis.
In this case, I don't think this meets that bar.
Let's add the string somewhere in the apex test classes. Currently it's only used in NuGetConsoleTestCase, so you can just define it there.
microsoft-github-policy-service
bot
added
the
Status:No recent activity
|
This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch. |
Bug
Fixes:
https://github.com/NuGet/Client.Engineering/issues/2898
Description
Based on discussion in the bug 2898, add the required package source for the “Microsoft.Android.Ref.34” package in MAUI test cases
PR Checklist